Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Docs: Add a router or multiplexer" #864

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

josmperez
Copy link
Contributor

Reverts #826 to incorporate missed suggestion

@josmperez josmperez added the no-changelog Don't include in changelog and version calculations label Apr 8, 2024
@josmperez josmperez self-assigned this Apr 8, 2024
@josmperez josmperez requested a review from a team as a code owner April 8, 2024 17:40
@josmperez josmperez requested review from sunker and removed request for a team April 8, 2024 17:40
Copy link

github-actions bot commented Apr 8, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@josmperez josmperez requested a review from marefr April 8, 2024 18:12
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor suggestion.

Sifenote: You didn't have to do a revert. Just checkout a new branch from latest main, make your changes, commit and push the branch and open the pr. For this PR doesn't really matter since the end result will be the same.

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
@josmperez josmperez requested a review from marefr April 8, 2024 21:43
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josmperez josmperez merged commit 99f63f9 into main Apr 8, 2024
12 checks passed
@josmperez josmperez deleted the revert-826-multiplex branch April 8, 2024 22:45
Ukochka pushed a commit that referenced this pull request Apr 16, 2024
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Don't include in changelog and version calculations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants