-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Instructions on how to write E2E tests for app plugins #891
Conversation
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mckn - Please take a look at my suggestions in my recent commits related to doc style, clarity, and so on. Many of these are related to doc style preference for simple indicative tense and avoidance of gerunds. Let me know if you have any questions.
Love it! There is only one thing that I would like to change. I'm adding a comment with your name to it so we can discuss it in this PR. Hope that is ok 🙏🏻 |
docusaurus/docs/e2e-test-a-plugin/test-an-app-plugin/app-pages.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this @mckn!
What this PR does / why we need it:
This PR provides some instructions on how to structure your E2E tests for app plugins. Hopefully it show case two different patterns for improving readability and to make it easier to share logic between tests.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a rough draft so feel free to provide bigger text changes that would make it easier to understand the documentation.