Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Document how to run queries in parallel #911

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

andresmgot
Copy link
Contributor

What this PR does / why we need it:

Documents grafana/grafana-plugin-sdk-go#988

Which issue(s) this PR fixes:

Fixes grafana/grafana-plugin-sdk-go#972

Special notes for your reviewer:

@andresmgot andresmgot requested a review from a team as a code owner May 16, 2024 13:32
@andresmgot andresmgot requested review from Ukochka and removed request for a team May 16, 2024 13:32
Copy link

github-actions bot commented May 16, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@@ -179,6 +179,30 @@ The following instructions are based on Grafana v10.1.1, consult the [documentat
1. Save the dashboard.
1. After some time the alert rule evaluates and transitions into _Alerting_ state.

## Run multiple queries concurrently
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this all red ? 🟥 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea. there doesn't seem to be a coding error.

@andresmgot andresmgot added the no-changelog Don't include in changelog and version calculations label May 16, 2024
Copy link
Contributor

@josmperez josmperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and a commit with minor edits. LGTM.

…s.md

Co-authored-by: Joseph Perez <45749060+josmperez@users.noreply.github.com>
@andresmgot andresmgot enabled auto-merge (squash) May 20, 2024 07:49
@andresmgot andresmgot merged commit 423a568 into main May 20, 2024
11 checks passed
@andresmgot andresmgot deleted the backendConcurrent branch May 20, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Don't include in changelog and version calculations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support for executing queries in parallel
2 participants