Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AsyncButtonCascader #1

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Adding AsyncButtonCascader #1

merged 2 commits into from
Nov 23, 2020

Conversation

srclosson
Copy link
Member

Used in the opcua plugin. The same as a regular button cascader, but uses loadData for an async experience.

@srclosson
Adding AsyncButtonCascader
872fa6b 
Used in the opcua plugin
@kminehart kminehart requested review from vickyyyyyyy and a team November 19, 2020 21:14
scottlepp
scottlepp approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@scottlepp scottlepp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would rename the file to match the name of the component: AsyncButtonCascader not ButtonCascader. helps when navigating

@scottlepp scottlepp self-requested a review November 20, 2020 19:13
scottlepp
scottlepp requested changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@scottlepp scottlepp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we missing the rc-cascader dependency? and grafana-ui? ...and are there unused dependencies?

src/ButtonCascader/ButtonCascader.tsx Outdated Show resolved Hide resolved
scottlepp
scottlepp reviewed Nov 20, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@srclosson srclosson self-assigned this Nov 23, 2020
@srclosson srclosson merged commit 85ed2ab into master Nov 23, 2020
@srclosson srclosson deleted the src/add-cascader branch November 23, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottlepp scottlepp scottlepp requested changes

@bossinc bossinc bossinc approved these changes

@kminehart kminehart Awaiting requested review from kminehart

@vickyyyyyyy vickyyyyyyy Awaiting requested review from vickyyyyyyy

Assignees

@srclosson srclosson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srclosson @bossinc @scottlepp