Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude files for build #10

Merged
merged 3 commits into from
Dec 8, 2020
Merged

chore: exclude files for build #10

merged 3 commits into from
Dec 8, 2020

Conversation

vickyyyyyyy
Copy link
Member

Currently we are building everything with the tsc command, including the tests and storybook files.

This means that when we install ui-enterprise in other projects, we will require dependencies such as chance and @testing-library to be installed.

Included a separate tsconfig.json file for the build to exclude these dependencies that we would only need during development and use it for build and postinstall.

Before:
Screenshot 2020-12-08 at 09 56 46

After:
Screenshot 2020-12-08 at 09 57 04

@vickyyyyyyy vickyyyyyyy requested a review from a team December 8, 2020 09:59
Copy link
Member

@srclosson srclosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Learned something new.

@vickyyyyyyy vickyyyyyyy merged commit 5ecad5e into master Dec 8, 2020
@vickyyyyyyy vickyyyyyyy deleted the exclude-for-build branch December 8, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants