-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding datasource picker and datalinks #17
Conversation
still super nervous about this repo 😬 Lets make sure it has a plan for how to stay in sync with core |
@ryantxu Don't be nervous! :D |
We should actually come up with a plan for this. Perhaps even print the plan in the README? I can talk to Luke and see if it's possible to set something up. |
We spoke to Alex and Luke and they suggested we have a regular (weekly or bi-weekly) sync space to gather all FE Enterprise and OSS things so everyone is aware of what's going on 😄 This way we can also discuss if any components we come up with can also be helpful in the core library. For more context, they agreed that while we do have Enterprise-specific UIs, it would be great to incorporate all the work into the design system and also a single UI library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good to see many tests being added! 🔥 🔥 🔥
Just left a few comments and nit suggestions 😄
I noticed the expect
assertions are inside of the act wrapper - the act
API is for wrapping interactions with your applications, like event firing, so the expect
assertions are normally left outside and not included within the wrapper.
I think the await
s within the act
wrappers can also be removed and another nit: the onChange handlers can be passed in jest.fn()
rather than () => {}
if we don't care about them
EDIT: Forgot to ask, can we add some stories for the new components so we have examples of their usages? 🙏
// import { Button } from '@grafana/ui'; | ||
// import { DataLink } from './DataLink'; | ||
// import { act } from 'react-dom/test-utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// import { Button } from '@grafana/ui'; | |
// import { DataLink } from './DataLink'; | |
// import { act } from 'react-dom/test-utils'; | |
// import { Button } from '@grafana/ui'; | |
// import { DataLink } from './DataLink'; | |
// import { act } from 'react-dom/test-utils'; |
Co-authored-by: Vicky Lee <36230812+vickyyyyyyy@users.noreply.github.com>
Co-authored-by: Vicky Lee <36230812+vickyyyyyyy@users.noreply.github.com>
The datasource picker and datalinks are used in Splunk, but decoupled so the control can be reusable