Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query row to exportable controls #2

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Conversation

srclosson
Copy link
Member

The PR adds the QueryEditorRow control, which acts as a single row for which you can add controls as children.

@srclosson srclosson self-assigned this Nov 23, 2020
@ryantxu
Copy link
Member

ryantxu commented Nov 23, 2020

What about:

<InlineField label="Query type" labelWidth={14} grow={true} tooltip={queryTooltip}>
            <Select
              options={siteWisteQueryTypes}
              value={currentQueryType}
              onChange={this.onQueryTypeChange}
              placeholder="Select query type"
              menuPlacement="bottom"
            />
          </InlineField>

if we need this on things older than 7.3... maybe copy it from grafana/ui?

@ryantxu
Copy link
Member

ryantxu commented Nov 23, 2020

i am slightly skeptical of this whole repo... unless it has planned obsolescence built in :)

@srclosson
Copy link
Member Author

Yeah, that's fair. I'm sure it's better than what we have, but maybe not quite as good as we can be. But it's a step forward. Actually, there are a few things I can do better with this control.

@srclosson srclosson merged commit 62f1c61 into master Nov 25, 2020
@srclosson srclosson deleted the src/add-query-row branch November 25, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants