fix: pin grafana deps to v7.4.1 and move react-calendar types dep #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vickyyyyyyy
changed the title
kminehart
approved these changes
Feb 11, 2021
|
do we need to do anything to release this change? |
I don't think so, we would just to re-gen our yarn.lock files in plugins that use this (since we haven't released this or versioned it for npm or anything) and I haven't found any breaking changes with this. I added a tag previously with the v7.4.0 so we know from which commit onwards it contains the v7.4.0 breaking changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the react-calendar types from devDeps to deps, otherwise we get an error when using the
DatePickerin pluginsAlso pinned the grafana deps to v7.4.1 rather than
nextso it's clearer what the version we are using