Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove type errors on postinstall build #32

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Conversation

srclosson
Copy link
Member

Prior to this change (without being this specific/explicit with the typings) the following errors were returned

src/components/DataSourcePicker/DataSourcePicker.tsx:37:3 - error TS2742: The inferred type of 'dataSourceSrv' cannot be named without a reference to 'ui-enterprise/node_modules/@grafana/runtime'. This is likely not portable. A type annotation is necessary.

37   dataSourceSrv = getDataSourceSrv();
     ~~~~~~~~~~~~~

src/components/DataSourcePicker/DataSourcePicker.tsx:97:3 - error TS2742: The inferred type of 'getDataSourceOptions' cannot be named without a reference to 'ui-enterprise/node_modules/@grafana/data'. This is likely not portable. A type annotation is necessary.

97   getDataSourceOptions() {
     ~~~~~~~~~~~~~~~~~~~~


Found 2 errors.

These changes fix those errors

@srclosson srclosson requested a review from a team February 25, 2021 18:56
@yesoreyeram yesoreyeram merged commit 630c843 into master Feb 25, 2021
@yesoreyeram yesoreyeram deleted the src/remove-type-errors branch February 25, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants