Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support AsyncSelect for selectOption #36

Merged
merged 4 commits into from
Mar 17, 2021

Conversation

vickyyyyyyy
Copy link
Member

Currently, the existing helper function for selecting an option is not enough for AsyncSelect because they don't have any options available until you start typing. This allows you to type the option label so it becomes available and then you can select it.

@vickyyyyyyy vickyyyyyyy requested a review from a team March 17, 2021 12:38
@vickyyyyyyy vickyyyyyyy self-assigned this Mar 17, 2021
Copy link
Member

@srclosson srclosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments 🔥

Copy link
Member

@srclosson srclosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vicky and jsdoc sitting in a tree...

@vickyyyyyyy vickyyyyyyy merged commit 0d981c4 into master Mar 17, 2021
@vickyyyyyyy vickyyyyyyy deleted the selectOpen-support-async branch March 17, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants