Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Cascader from grafana/ui #37

Merged
merged 4 commits into from
Apr 7, 2021
Merged

chore: use Cascader from grafana/ui #37

merged 4 commits into from
Apr 7, 2021

Conversation

vickyyyyyyy
Copy link
Member

@vickyyyyyyy vickyyyyyyy commented Apr 7, 2021

First half of this ticket: https://github.com/grafana/plugins-private/issues/1339

Use Cascader from grafana/ui now that the changes we want are out in a Grafana release instead of this copy - see more: https://github.com/grafana/ui-enterprise/blob/master/README.md#unreleased-components

  • Update our grafana/ui to latest 7.5.3
  • Remove our copy of Cascader in unreleasedComponents
  • Export the Cascader from grafana/ui
  • Update Segment tests (looks like 7.5.3 has made some changes to it so the tests needed updating)

@vickyyyyyyy vickyyyyyyy requested a review from a team April 7, 2021 15:17
Copy link
Member

@srclosson srclosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vickyyyyyyy vickyyyyyyy merged commit fb9c2b7 into master Apr 7, 2021
@vickyyyyyyy vickyyyyyyy deleted the cascader-7.5.3 branch April 7, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants