Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Storybook and Chance.js #4

Merged
merged 4 commits into from
Nov 27, 2020
Merged

chore: add Storybook and Chance.js #4

merged 4 commits into from
Nov 27, 2020

Conversation

vickyyyyyyy
Copy link
Member

@vickyyyyyyy vickyyyyyyy commented Nov 27, 2020

Added Storybook so we can easily view our UI components, in addition to Chance.js which can be used to generate content for the components if we cba thinking of fixtures.

Work done:

  • Added Storybook
  • Added dark theme to Storybook
  • Added Chance.js
  • Added initial story with QueryRowEditor as an example of Storybook and Chance.js usage
  • Updated README for Storybook

Out of scope/future work:

Screenshots:

  • Storybook main page
    Screenshot 2020-11-27 at 11 38 36

  • QueryRowEditor basic story
    Screenshot 2020-11-27 at 11 38 46

@vickyyyyyyy vickyyyyyyy requested a review from a team November 27, 2020 11:41
Copy link
Member

@srclosson srclosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! LGTM. One request: Can you run this through prettier?

@srclosson srclosson merged commit 78f60f2 into master Nov 27, 2020
@srclosson srclosson deleted the add-storybook branch November 27, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants