Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for feature toggle for health diagnostics #42

Merged
merged 2 commits into from
May 6, 2021

Conversation

vickyyyyyyy
Copy link
Member

@vickyyyyyyy vickyyyyyyy commented May 6, 2021

Add support for toggling our healthDiagnosticsErrorsCompat return.

This is because for the new health diagnostic error messages, we are planning to beta release them first so we want them to be switched off by default.

Usage in our plugins:

import { healthDiagnosticsErrorsCompat } from 'ui-enterprise';
import toggles from './featureToggles';

async testDatasource() {
    return healthDiagnosticsErrorsCompat(super.testDatasource.bind(this), toggles.healthDiagnosticsErrors);
}

@vickyyyyyyy vickyyyyyyy requested a review from a team May 6, 2021 12:06
Copy link
Contributor

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vickyyyyyyy vickyyyyyyy merged commit 2dfb29f into master May 6, 2021
@vickyyyyyyy vickyyyyyyy deleted the feature-toggle-test-datasource branch May 6, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants