Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Various changes to get plugin ui to compile with grafana 8 librarys #48

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Chore: Various changes to get plugin ui to compile with grafana 8 librarys #48

merged 3 commits into from
Jul 20, 2022

Conversation

srclosson
Copy link
Member

These changes are to fix issues with

  • newer versions of react
  • newer versions of grafana libraries (useStyles2 vs useStyles)
  • Update core libraries from Grafana 7 to Grafana 8 now that Grafana 9 is released.

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

yesoreyeram
yesoreyeram approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me.
Refer grafana/grafana#36624 to fix issues in matchmedia

@srclosson srclosson merged commit 8a98f0c into main Jul 20, 2022
@srclosson srclosson deleted the src/update-plugin-ui branch July 20, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesoreyeram yesoreyeram yesoreyeram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srclosson @CLAassistant @yesoreyeram