Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifiying the purpose #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarifiying the purpose #54

wants to merge 1 commit into from

Conversation

tolzhabayev
Copy link

Afaik this package is internal only. If that is the case - it should be labeled as such here and on npmjs to avoid confusion.

@tolzhabayev tolzhabayev self-assigned this Oct 24, 2022
@tolzhabayev
Copy link
Author

@scottlepp @jackw review please?
My goal is to reduce confusion until we have a clear direction.

@scottlepp
Copy link
Contributor

scottlepp commented Nov 8, 2022

@tolzhabayev we do use this in open source plugins. We can't use newer components from Grafana UI since they aren't compatible with older versions of Grafana that we have to support with plugins. So we put those components we want to share between plugins here.

Copy link
Contributor

@scottlepp scottlepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is accurate since we use it in open source plugins.

@tolzhabayev
Copy link
Author

tolzhabayev commented Nov 8, 2022

Is this package used in any community plugins?

I mainly want to avoid confusion for the plugin developers in terms of:

  • How does it differ from @grafana/ui
  • Can I use this package to build a plugin as a plugin author in our community? <- we will most likely not accept any community plugin that is currently using this package and ask them to use @grafana/ui instead.
  • Will this package be supported in the same way as other packages we offer to plugin authors?

To me it feels like the discussion on the future of how to handle what / which components should be where and when, etc. is still ongoing.

My intention is to reduce spread of this package to plugins that are created by grafana (even if open source, if it helps think about signatureType) until we have alignment on the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants