Secure Socks Proxy: Add UI toggle to plugin-ui #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehingtgen
requested review from
asimpson,
academo,
yesoreyeram and
scottlepp
scottlepp
requested changes
Jul 1, 2023
Done! |
yesoreyeram
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
This PR add a UI toggle that will be used across all plugins as we go through enabling the use of the secure socks proxy to proxy datasource connections. Today, this toggle exists in all core and enterprise datasources, but we want to standardize the UI across all datasources.
The toggle should only appear when the Grafana instance is able to run the proxy and has it set up, i.e:
secure_socks_datasource_proxy.enabled). This value is passed to the runtime config here.Demos:
Video
The corresponding wavefront code can be viewed here. Note: here the proxy is not set up locally to demonstrate how the backend changes when the proxy is toggled on vs off.
Other info:
Slack thread