Api query editor #84
Api query editor #84
Conversation
| <div> | ||
| {api.inputs.map((iv: InputValue, i) => { | ||
| const val = value(query, i, iv.defaultValue); | ||
| return <div className="gf-form" key={i}> |
There was a problem hiding this comment.
From what I know gf-form classes is legacy. Could we use InlineField component instead?
| onChange={(selected: SelectableValue<string>, _: ActionMeta) => onChangeSelect(selected, i)} | ||
| /> | ||
| } | ||
| {!iv.choices && !iv.lookup && |
There was a problem hiding this comment.
Seems like lookup, choices etc. are mutually exclusive and I'd suggest to rethink the InputValue shape. I'd suggest to have something like type field in it which can have a limited number of options like select , asyncselect, input, etc. And I think value / options can be different depending on the type.
The reason I am suggesting this is I think in this way it will be more future proof. Maybe in the future we would want to also render the options as a radio buttons, etc. And for such cases I think we should create API in a way that it's easily extendible. It might be hard to change the API when plugins start using it.
| @@ -21,3 +21,4 @@ export { InlineSwitch, CertificationKey } from '@grafana/ui'; | |||
| export * from './QueryEditor'; | |||
| export * from './ConfigEditor'; | |||
| export { CustomHeadersSettings } from './CustomHeadersSettings/CustomHeadersSettings'; | |||
| export { ApiQueryEditor } from './ApiQueryEditor/ApiQueryEditor'; | |||
There was a problem hiding this comment.
We should probably also export the types so that we can consume them in plugins.
| <InlineFormLabel tooltip={iv.description}> | ||
| {pretty(iv.name)} | ||
| </InlineFormLabel> |
There was a problem hiding this comment.
I think it's better to provide the label separately than to try to prettify inner name of the field, they might not always match.
Example ("Eventtype" might be ok for id, but the label should be "Event type" I think):
component for rendering rest api inputs