Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: allow dataset selection to be disabled #92

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

gwdawson
Copy link
Member

in postgres-based datasources we don't use datasets. this pr allows datasources to decide if they want to use datasets.

if datasets are disabled, it will use datasource.dataset as the database.

@gwdawson gwdawson self-assigned this Mar 26, 2024
@gwdawson gwdawson requested a review from a team March 27, 2024 11:03
@gwdawson
Copy link
Member Author

@grafana/enterprise-datasources / @grafana/partner-datasources
can i please get a review on this from your side also as databricks and astradb use this component.

@gwdawson gwdawson changed the title sql: all dataset selection to be disabled sql: allow dataset selection to be disabled Mar 27, 2024
Copy link

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, you've keep the default behaviour as the current one so there should be no changes needed by us afaict?

@gwdawson gwdawson merged commit aea89f5 into main Apr 15, 2024
1 check passed
@gwdawson gwdawson deleted the gareth/sql-allow-disable-datasets branch April 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants