-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved way of disable datasets #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor
reviewed
Apr 19, 2024
gabor
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
gwdawson
requested review from
a team
and removed request for
yesoreyeram and
alyssabull
May 3, 2024 11:50
@grafana/enterprise-datasources can i please get a review from your side also, nothing needs to change in your datasources as the default behaviour is still to "use datasets" |
Multimo
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently if you want to disable datasets you need to do the following:
enableDatasets = false
prop into SqlQueryEditor.toRawSql
function, that doesn't expect a datasetthis pr removes the need for code duplication in all datasources with disabled datasets by no longer requiring a custom
toRawSql
function.this pr also also changes where you declare
disableDatasets
, this is now declared in datasource.ts opposed to previously this was just a prop in the builder component.after this pr is merged, the only thing you need to do is add the flag
disableDatasets: true
to the getDB function inside ofdatasource.ts
.