Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate plugin signature type if present #134

Closed
academo opened this issue Sep 5, 2023 · 2 comments · Fixed by #136
Closed

Validate plugin signature type if present #134

academo opened this issue Sep 5, 2023 · 2 comments · Fixed by #136
Assignees
@academo
Labels
enhancement New feature or request

Comments

@academo
Copy link
Member

academo commented Sep 5, 2023

Make sure community or commercially signed plugins don't have a rootUrl restriction.
@academo academo added the enhancement New feature or request label Sep 5, 2023
@academo academo self-assigned this Sep 5, 2023
@xnyo
Copy link
Member

xnyo commented Sep 7, 2023

@academo There's also this check that is not implemented by plugin-validator but it's implemented in Grafana:

https://github.com/grafana/grafana/blob/ad63400a5417c5b53702149cd0467be97d89386a/pkg/plugins/manager/signature/manifest.go#L224

(the plugin shouldn't have any files that are not in MANIFEST.txt)

The other checks are implemented.

@academo
Copy link
Member Author

academo commented Sep 7, 2023

@xnyo we have that check in place https://github.com/grafana/plugin-validator/blob/main/pkg/analysis/passes/manifest/manifest.go#L67

@academo academo mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@academo academo

Labels
enhancement New feature or request
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add validation for a signature to not contain rootUrls grafana/plugin-validator
2 participants
@academo @xnyo