Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for a signature to not contain rootUrls #136

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

academo
Copy link
Member

@academo academo commented Sep 7, 2023

Validate that signatures don't contain a rootUrl when they are not signed as private plugins

Closes #134

@academo academo requested a review from xnyo September 7, 2023 11:46
@academo academo self-assigned this Sep 7, 2023
@academo academo added the enhancement New feature or request label Sep 7, 2023
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
@academo academo requested a review from xnyo September 7, 2023 12:57
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work! 👍

@academo academo merged commit 0c1a268 into main Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Validate plugin signature type if present
2 participants