Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new plugin-tools creates source map files with plugin-id included in webpack path #140

Closed
briangann opened this issue Oct 20, 2023 · 2 comments · Fixed by #141
Closed

new plugin-tools creates source map files with plugin-id included in webpack path #140

briangann opened this issue Oct 20, 2023 · 2 comments · Fixed by #141
Assignees
Labels
bug Something isn't working

Comments

@briangann
Copy link
Collaborator

briangann commented Oct 20, 2023

when using yarn v3/v4 (and any other package manager), the source map file ends up with paths like this:

webpack://briangann-gauge-panel/webpack/bootstrap
webpack://briangann-gauge-panel/./components/TickMaps/TickMapItem.tsx

the sourcediff code is only removing the leading webpack:// which results in the tool reporting the source does not match

this was encountered using the standard plugin-tools environment but with yarn v3 in this repo https://github.com/briangann/grafana-gauge-panel/releases/tag/v2.0.0

@briangann briangann added the bug Something isn't working label Oct 20, 2023
@briangann briangann self-assigned this Oct 20, 2023
@briangann
Copy link
Collaborator Author

this doesn't appear to be limited to yarn v3, the current create-plugin setup is generating the source maps with the same paths as above

@jackw
Copy link

jackw commented Oct 23, 2023

As you've already discovered @briangann this isn't to do with package managers. Based on the logs I'm inclined to think it's due to the changes in the webpack config which enable lazy loading and prevent the additional webpack runtimes from conflicting.

@briangann briangann changed the title yarn v3 creates source map files with plugin-id included in webpack path new plugin-tools creates source map files with plugin-id included in webpack path Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants