Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support arm64 and new webpack source map diffs #141

Merged
merged 20 commits into from
Oct 26, 2023
Merged

Feature: Support arm64 and new webpack source map diffs #141

merged 20 commits into from
Oct 26, 2023

Conversation

briangann
Copy link
Collaborator

@briangann briangann commented Oct 20, 2023 •
edited

  • refactored getPluginId to be a utility function that can be re-used
  • implements changes needed to support source maps generated by new plugin-tools webpack configuration
  • updated command line tools as needed to use new params

Note: this is a general fix for the current webpack configuration and is not specific to Yarn V3.

Fixes: #140

@briangann briangann requested review from xnyo and marefr October 20, 2023 11:56
@briangann briangann self-assigned this Oct 20, 2023
@briangann briangann added the bug Something isn't working label Oct 20, 2023
xnyo
xnyo reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 😄 Leaving some comments:

pkg/sourcemap/sourcemap.go Outdated Show resolved Hide resolved
.vscode/launch.json Show resolved Hide resolved
@briangann
Copy link
Collaborator Author

think we're good to go here, changes have been applied and tests are passing

@briangann briangann requested a review from xnyo October 24, 2023 02:49
@briangann briangann changed the title Feature: Support arm64 and yarn v3 source map diffs Feature: Support arm64 and new webpack source map diffs Oct 25, 2023
xnyo
xnyo approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome 🚀

@briangann briangann merged commit 21fbe4e into main Oct 26, 2023
3 checks passed
@briangann briangann deleted the 20231019_support_arm64 branch October 26, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xnyo xnyo xnyo approved these changes

@marefr marefr Awaiting requested review from marefr

Assignees

@briangann briangann

Labels
bug Something isn't working
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new plugin-tools creates source map files with plugin-id included in webpack path
2 participants
@briangann @xnyo