osv-scanner used as a library with more reliable filtering #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangann
commented
Mar 30, 2023
pkg/analysis/passes/osvscanner-internal/osv_scanner_internal.go
Outdated
Show resolved
Hide resolved
briangann
commented
Mar 30, 2023
briangann
commented
Mar 30, 2023
pkg/analysis/passes/osvscanner-internal/osv_scanner_internal.go
Outdated
Show resolved
Hide resolved
academo
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Thanks for the work you put on this one @briangann !
We should follow up this with a packageJson.lock scanning and protection since there are plugins using npm or pnpm and we are about to introduce support for them here grafana/plugin-tools#226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a revamped osv-scanner that calls the latest version (1.2.0) as a library instead of spawning a process.
Filtering has also been modified to auto-detect issues attributed to
@grafana/*packages, without enumerating any of the details. This is effectively a generic/automated allow list no matter which version of the grafana packages are used.The old spawned method has been removed