Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky test #114

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Skip flaky test #114

merged 2 commits into from
Apr 17, 2023

Conversation

academo
Copy link
Member

@academo academo commented Apr 17, 2023

The current OSV scanner tests are not deterministic since the library could get new reports on its database that affect the existing testdata making some tests that originally passed, fail.

While @briangann works on the mocking mechanism to make these tests deterministic I'm skipping this test so we can release this version of the validator

@academo academo requested a review from briangann April 17, 2023 07:39
@academo academo self-assigned this Apr 17, 2023
@academo academo added the bug Something isn't working label Apr 17, 2023
@academo academo merged commit 00484d2 into main Apr 17, 2023
1 check passed
@academo academo deleted the academo/fix-osv-test branch April 17, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants