Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SVG files for sourcemap diff #116

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

academo
Copy link
Member

@academo academo commented Apr 17, 2023

Ignores svg files to check content diff. SVG files are already verified for malicious code in another check and generally webpack will reprocess them into module imports that will keep reporting false negatives

@academo academo self-assigned this Apr 17, 2023
@academo academo added the bug Something isn't working label Apr 17, 2023
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@academo academo merged commit 609cda1 into main Apr 17, 2023
1 check passed
@academo academo deleted the academo/ignore-svg-diff-files branch April 17, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants