Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignores files that contain pnpm folder structure signature #119

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Ignores files that contain pnpm folder structure signature #119

merged 1 commit into from
Apr 20, 2023

Conversation

academo
Copy link
Member

@academo academo commented Apr 20, 2023

Adds pnpm folder structure to sourcemaps validation.

Grafana toolkit has a tendency to add node_modules files from pnpm and generates false positives in the validator

@academo academo self-assigned this Apr 20, 2023
@academo academo added the bug Something isn't working label Apr 20, 2023
@academo academo merged commit 3024d45 into main Apr 20, 2023
3 checks passed
@academo academo deleted the academo/fix-false-positive-with-pnpm branch April 20, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@tolzhabayev tolzhabayev Awaiting requested review from tolzhabayev

Assignees

@academo academo

Labels
bug Something isn't working
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@academo @jackw