Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to use the first available plugin.json if not found in the expected location #132

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fallback to use the first available plugin.json if not found in the expected location #132

merged 2 commits into from
Aug 28, 2023

Conversation

academo
Copy link
Member

@academo academo commented Aug 28, 2023 •
edited

  • Fallbacks to detect the plugin id from the first plugin.json if not found in the expected location
  • Correctly finds if the code provided in a zip file is inside a subdirectory.

@academo academo requested review from xnyo and briangann August 28, 2023 10:56
briangann
briangann approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@academo academo merged commit c99b569 into main Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangann briangann briangann approved these changes

@xnyo xnyo Awaiting requested review from xnyo

Assignees
No one assigned
Labels
None yet
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@academo @briangann