Add checksum validation #166
Conversation
academo
requested review from
leventebalogh,
wbrowne,
andresmgot,
oshirohugo and
xnyo
and removed request for
a team
| SourceCodeDir string | ||
| ResultOf map[*Analyzer]interface{} | ||
| Report func(string, Diagnostic) | ||
| AnalyzerName string |
There was a problem hiding this comment.
Since we are passing more global data to the analyzers I decided to move these parameters to its own object instead of having this function positional parameters growing ever more.
This required some minor changes in other test files and the runner but the functionality remains untouched
| RootDir: filepath.Join("./"), | ||
| SourceCodeDir: filepath.Join("testdata", "version-match"), | ||
| RootDir: filepath.Join("./"), | ||
| CheckParams: &analysis.CheckParams{ |
There was a problem hiding this comment.
Changing this since we moved to an object instead of positional parameters
| if sourceCodeDir == "" { | ||
| // If no source code dir is provided, only report the result if ReportAll is set, for backwards compatibility | ||
| if sourceCodeNotProvided.ReportAll { | ||
| pass.ReportResult(pass.AnalyzerName, sourceCodeNotProvided, fmt.Sprintf("Source code not provided or the provided URL %s does not point to a valid source code repository", pass.SourceCodeDir), "If you are passing a Git ref or sub-directory in the URL make sure they are correct.") | ||
| pass.ReportResult( |
There was a problem hiding this comment.
breaking down these long lines for easier reading. no changes in text.
pkg/cmd/plugincheck2/main.go
Outdated
| diags, err := runner.Check(passes.Analyzers, archiveDir, sourceCodeDir, cfg) | ||
| diags, err := runner.Check( | ||
| passes.Analyzers, | ||
| &analysis.CheckParams{ |
There was a problem hiding this comment.
This is the change from positional parameters to an object with global data we can pass to the analyzers.
|
|
||
| resp, err := client.Get(url) | ||
| if err != nil { | ||
| logme.DebugFln("Error reading body: %s", err.Error()) |
There was a problem hiding this comment.
Nit: this is an error making the network request not while reading the body so I would change the logged message to something more clear
Add checksum validator with cli parameter