Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum handling of wrong urls #169

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix checksum handling of wrong urls #169

merged 1 commit into from
Mar 1, 2024

Conversation

academo
Copy link
Member

@academo academo commented Mar 1, 2024

Fix an error when the url returns empty content. This can happen if the provided url is to a download service or a page to see the checksum instead of a raw checksum

@academo academo requested review from a team as code owners March 1, 2024 16:15
@academo academo requested review from leventebalogh, wbrowne, marefr and xnyo and removed request for a team March 1, 2024 16:15
Copy link
Collaborator

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@academo academo merged commit e142525 into main Mar 1, 2024
3 checks passed
@academo academo deleted the academo/fix-checksum branch March 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants