Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzer to check on empty description or keywords #175

Merged

Conversation

oshirohugo
Copy link
Contributor

@oshirohugo oshirohugo commented Mar 22, 2024

Add new analyzer to warn on empty descriptions or empty keywords, this is made to allow encourage authors to provide data for better plugin discoverability.

Closes #167

@oshirohugo oshirohugo self-assigned this Mar 22, 2024
@oshirohugo oshirohugo requested review from a team as code owners March 22, 2024 16:34
@oshirohugo oshirohugo requested review from Ukochka, wbrowne, andresmgot and xnyo and removed request for a team March 22, 2024 16:34
@oshirohugo oshirohugo added the enhancement New feature or request label Mar 22, 2024
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! 🙌 🙌

I only have noticed a few things regarding the analyzer definition:

pkg/analysis/passes/discoverability/discoverability.go Outdated Show resolved Hide resolved
pkg/analysis/passes/discoverability/discoverability.go Outdated Show resolved Hide resolved
oshirohugo and others added 2 commits March 25, 2024 09:09
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work! 🙌

@oshirohugo oshirohugo merged commit eae1404 into main Mar 25, 2024
3 checks passed
@oshirohugo oshirohugo deleted the add-analyzer-to-warn-on-empty-description-or-keywords branch March 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

new analyzer: warn on empty description and keywords in plugin.json
2 participants