CI: Update GitHub Action to build Docker container #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the GitHub Action
test.yml
so it builds the Docker container, rather than running the tests and build step directly inside GitHub Actions.Right now, the GitHub Action is doing the same steps as the ones in the Dockerfile:
plugin-validator/Dockerfile
Lines 1 to 16 in 45b483c
With this PR, the GH action will trigger a Docker image build. This is better because whenever we change the build/test steps (or the golangci-lint, semgrep or gosec versions), we don't have to update the GH action workflow as well as the Dockerfile.
This is also the same approach used in the drone pipeline, where the "build + test + push" step simply builds the Docker container:
plugin-validator/.drone.yml
Lines 4 to 14 in 45b483c