Add analyzer to detect standalone backend debug files #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
reviewed
Mar 3, 2023
academo
reviewed
Mar 3, 2023
academo
reviewed
Mar 3, 2023
|
Could you add a row in https://github.com/grafana/plugin-validator#analyzers to document the analyzer? Apologies for adding new requirements mid PR! |
|
No worries @sympatheticmoose ! I have changed the README, let me know what you think :) |
sympatheticmoose
approved these changes
Mar 6, 2023
academo
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend plugins support debug mode, which is implemented by placing a
standalone.txtfile in the dist folder, which will tell Grafana to connect to a GRPC server running on the address specified in that file.Having this file in a production plugin makes it effectively unusable.
This analyzer also checks for
pid.txt, which will be added by grafana/grafana-plugin-sdk-go#621 and will be used for backend debug mode (for plugins that use a new version of the SDK).