Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme #90

Merged
merged 3 commits into from
Mar 3, 2023
Merged

update readme #90

merged 3 commits into from
Mar 3, 2023

Conversation

sympatheticmoose
Copy link
Contributor

@sympatheticmoose sympatheticmoose commented Mar 3, 2023

This PR makes a number of changes to the readme:

  • General rewordings and expanding on details
  • Adds CI and Go Report Shields
  • Removes arguably unnecessary content in the npx/local examples and strips some content from example output
  • Replaces the Analyzers section with a new table format to save space and specifies the function names for each analyzer
  • Removes reference for feature requests on additional git providers
  • Updates npx command to add @latest to ensure users always run latest version and dont hit potential issues due to cached versions
  • Adds new getting help section which has a generic "raise feature request" call to action
  • Adds new Analyzers to the table and attempts to explain them. Some (listed below) seemingly don't appear even in tool output even when reportAll: true is configured, so may need removing? Perhaps they can't be configured individually through a config file?
    • gomanifest
    • jssourcemap
    • pluginname
    • logos
    • sourcecode
    • published (guessing just used in version?)
    • unsafesvg
  • It advises that private repositories are not supported (assumption)

Potential follow ups and questions not addressed through this PR:

  • Are local git repositories (not just zips) supported for -sourceCodeUri?
  • Are non-git locations supported for remote zip files i.e. FTP servers?
  • Can we share or reference the Grafana Labs configuration required for publishing to the catalog (is this the default behaviour)?
  • Can the naming convention be shared?
  • Add (at least) code of conduct and contributing guidelines
  • The local steps will only work if the user has set up their $PATH appropriately, maybe worth advising, might be too much detail?

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tolzhabayev tolzhabayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent update!

```
❯ plugincheck2 -help
Usage plugincheck2:
-config string (optional)
Path to configuration file
-sourceCodeUri string (optional)
URI to the source code of the plugin. If set, the source code will be downloaded and analyzed. This can be a ZIP file URL, an URL to git repository or a local file (starting with `file://`)
URI to the source code of the plugin. If set, the source code will be downloaded and analyzed. This can be a ZIP file URL, a URL to git repository or a local file (starting with `file://`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edit (an is correct before URL)

an URL to a git repository, or a local file (starting with file://)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always debate this 😄 Google suggests a URL (which does read more naturally imo) - source1 source2

@sympatheticmoose sympatheticmoose merged commit f8ca749 into main Mar 3, 2023
@sympatheticmoose sympatheticmoose deleted the readme-updates branch March 3, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants