Ignore css files in the validator source map check #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
added
bug
academo
commented
Mar 7, 2023
| @@ -56,7 +56,7 @@ func sourceCodeUriToLocalPath(sourceCodeUri string) (string, func(), error) { | |||
| // if it is an url to a git repo, clone it | |||
| if (len(sourceCodeUri) > 4 && sourceCodeUri[:4] == "http") || (len(sourceCodeUri) > 3 && sourceCodeUri[:3] == "git") { | |||
| fmt.Println(":: URL found. Trying to clone repository...") | |||
| sourceCodePath, cleanup, err = repotool.CloneToTempDir(sourceCodeUri, "") | |||
| sourceCodePath, cleanup, err = repotool.GitUrlToLocalPath(sourceCodeUri) | |||
There was a problem hiding this comment.
This method allows you to pass refs in the url instead of only the plain git url.
xnyo
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.