Expand list of allowed licenses to include BSD #97
Conversation
academo
commented
Mar 8, 2023
academo
commented
- Expand allowed licences and use regex instead of strings
- Add clarification comment
There was a problem hiding this comment.
The readme section on the analyzers lists the previously accepted list. Given this expansion I suggest adding under https://github.com/grafana/plugin-validator#license a new statement:
We accept the following licenses for community plugins: BSD, MIT, Apache 2.0, LGPL3, GPL3, AGPL3.
Then change the description for the license analyzer in https://github.com/grafana/plugin-validator#analyzers to be:
Ensures the [license type](https://github.com/grafana/plugin-validator#license) specified is allowed.
Eventually we should also update the main docs as well to make sure this is clear up front. Until theres a better place, we should probably just update the error message so instead of linking to https://grafana.com/licensing/, again link to https://github.com/grafana/plugin-validator#license
| @@ -89,13 +89,14 @@ Usage plugincheck2: | |||
| If set, plugincheck returns non-zero exit code for warnings | |||
There was a problem hiding this comment.
I applied prettier formatting to this file for more legibility
There was a problem hiding this comment.
LGTM
@sympatheticmoose if you are up to it and want to dig into how our main docs at grafana/grafana work - you could add a "license" section to https://grafana.com/docs/grafana/latest/developers/plugins/publishing-and-signing-criteria/
| require.Len(t, interceptor.Diagnostics, 0) | ||
| } | ||
|
|
||
| func TestInvalidUnilicenseLicense(t *testing.T) { |
There was a problem hiding this comment.
Nit: Typo: The name of the license is "unlicense" 😃
