Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin update #11

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Mixin update #11

merged 4 commits into from
Apr 24, 2023

Conversation

v-zhuravlev
Copy link

  1. Fix cache hit ratio panel

This rounds to .001, otherwise cache hit axis was showing multiple points with 100% since
values were rounded at axis, but not raw values, which changes from 0.9900001 were shown 0.9900002 on graphs, causing visual noise)

  1. Use psql specific metric to avoid return of postgres unrelated instances
  2. Change graphs to timeseries
  3. Move QPS to left and remove transparency for common style
  4. Fix conflict/deadlock metrics

These metrics are gauges, so applying rate is not required
screenshot-new

TIP: check diff commit, for better view.

This rounds to .001, otherwise cache hit axis was showing multiple points with 100% since
values were rounded at axis, but not raw values,  which changes from  0.9900001 were shown 0.9900002 on graphs, causing visual noise)

Signed-off-by: Vitaly Zhuravlev <zhuravlev.vitaly@gmail.com>
Use psql specific metric to avoid return of postgres unrelated instances

Signed-off-by: Vitaly Zhuravlev <zhuravlev.vitaly@gmail.com>
Move QPS to left and remove transparency

Signed-off-by: Vitaly Zhuravlev <zhuravlev.vitaly@gmail.com>
These metrics are gauges, so applying rate is not required

Signed-off-by: Vitaly Zhuravlev <zhuravlev.vitaly@gmail.com>
Copy link

@gaantunes gaantunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes.

@v-zhuravlev v-zhuravlev merged commit f67fcd2 into master Apr 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants