This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Add request decomposition with directories #31
Merged
robingustafsson
merged 29 commits into
grafana:master
from
bookmoons:bookmoons/request-decomp-dir
Jul 24, 2019
Merged
Add request decomposition with directories #31
robingustafsson
merged 29 commits into
grafana:master
from
bookmoons:bookmoons/request-decomp-dir
Jul 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node bin/postman-to-k6.js example/v2/box.json -s export default function() {
group("Collaborations", function() {
postman[Request]("Get Pending Collaborations");
postman[Request]("Retrieve a Collaboration");
postman[Request]("Retrieve all Collaborations");
postman[Request]("Add a Collaboration");
postman[Request]("Edit a Collaboration");
postman[Request]("Remove a Collaboration");
});
group("Comments", function() {
postman[Request]("Get Information About a Comment");
postman[Request]("Add a Comment to a File");
postman[Request]("Add an '@' Comment to a File");
postman[Request]("Add an Reply Comment to a File");
postman[Request]("Change a Comment's Message");
postman[Request]("Delete a Comment");
});
group("Events", function() {
postman[Request]("Get Events for a User");
postman[Request]("Get a Specific Event in an Enterprise");
postman[Request]("Get Events in an Enterprise");
});
group("Files", function() {
postman[Request]("Download a File");
postman[Request]("Get Information about a File");
postman[Request]("View the Comments on a File");
postman[Request]("Get a Thumbnail for a File");
.. |
This was referenced May 6, 2019
Apologies for the delay. Looking at this now. Running the box example from above I get:
Also, I think the filenames should be filtered a bit. The box example produces filenames like |
Strange. I'll put it on my list to look into this. Thanks for looking it over. |
Prevents conflict with Node.js builtin module util.
No longer used.
The iterative version was replaced with a recursive version to preserve directory structure.
Strips filenames of everything except A-Za-z0-9, space, dash. Replaces each sequence of consecutive spaces with a single dash.
Lost it in a rebase.
Regex was interpreting dash as character range.
bookmoons
force-pushed
the
bookmoons/request-decomp-dir
branch
from
July 12, 2019 05:30
9272bdf
to
dad7273
Compare
Think I've got this error fixed, and implemented that filename encoding. Did the encoding like this:
|
@bookmoons Thanks, works and LGTM, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds command line option
--separate/-s
which generates a separate file per request.Generated files define the request through the shim. The main logic then invokes requests by name.
Files are generated into a directory structure matching the tree defined in the Postman collection. File and folder name collisions are suffixed alphabetically, A B etc.
Closes #24.