Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Auth: Implemented ApiKey Authorization #57

Merged
merged 7 commits into from
May 22, 2020
Merged

Auth: Implemented ApiKey Authorization #57

merged 7 commits into from
May 22, 2020

Conversation

chrispader
Copy link
Contributor

This pull request should make the Postman "API Key" Authorization available on collections.

I would appreciate if this feature could be included, it is longingly needed in another project, which also uses postman-to-k6 for automated load testing with Postman Tests.

Kind Regards

Christoph Pader

@simskij
Copy link
Contributor

simskij commented Apr 29, 2020

Hi,

Thank you for your contributions. I'd love to include this, however, the tests are currently failing. Would you mind having a look at that?

Thanks again,
Simme

@chrispader
Copy link
Contributor Author

Ok, so i just have one question @simskij ... How are you building the production script (in ./bin, the one that is included with the npm-package), so i can test the functionality before pushing to the repo.. can't seem to find a 'main' property in package.json or any building script.

Kind regards

@simskij
Copy link
Contributor

simskij commented Apr 30, 2020

You shouldn't need to build anything. Running the "bin" in ./bin/postman-to-k6.js will use the code in the lib folder.

@chrispader
Copy link
Contributor Author

@simskij error fixed, tests are passing! :-)
I can confirm the authentication is working and the header is being added.

I still have another question... As of now, pm.collectionVariables is not supported or is it? Because when running the generated script pm.collectionVariables.<key> throws an error, as it is undefined.. Maybe this feature could be implemented or i would have a look at it.

Kind regards

Christoph Pader

@chrispader
Copy link
Contributor Author

Hey @simskij ! Is this still being reviewed?

Kind regards
Chris

@simskij
Copy link
Contributor

simskij commented May 22, 2020

LGTM! Merging. Regarding collectionVariables; from what I can tell there is no explicit support for this, sounds great if you'd like to have a look at it. Let me know if I can assist you in any way.

@simskij simskij merged commit 28f35cd into grafana:master May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants