This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
Bug #78: The moduleSpecifier "./libs/shim/urijs.js" couldn't be found on local disk. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js" couldn't be found on local disk. Added a alternate path when the setting "separate" is used.
added 2 commits
March 4, 2021 11:07
…s" couldn't be found on local disk. Added a alternate path when the setting "separate" is used.
… handling for the "libs" that are imported
|
@simskij Do you have some remarks or things I should change with regards to this PR? I'm using it as a patch for the NPM release 1.1.0, and it does the trick for me but perhaps you have comments to make it better. |
|
Hi! Sorry for keeping you waiting! I just need to try this out prior to merging it, then we should be good to go. Thank you for your contribution! Best, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug for #78 : "The moduleSpecifier "./libs/shim/urijs.js" couldn't be found on local disk."
Added a alternate path when the setting "separate" is used.
By checking the the setting and alternate urijs.js will be used.