New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture and expose notification delivery errors #31

Merged

gotjosh merged 2 commits into main from feature/errors-in-notifications

Jan 19, 2023

santihernandezc commented Jan 19, 2023

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the /api/v2/receivers endpoint.

santihernandezc force-pushed the feature/errors-in-notifications branch from 2b95b71 to 42cc05b Compare

January 19, 2023 17:21


          Capture and expose notification delivery errors

6ef0570

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

gotjosh force-pushed the main branch from 002d8ba to f59460b Compare

January 19, 2023 17:22


          Merge branch 'main' of https://github.com/grafana/prometheus-alertman…

f58105d

…ager into feature/errors-in-notifications

santihernandezc force-pushed the feature/errors-in-notifications branch from 42cc05b to f58105d Compare

January 19, 2023 17:43

gotjosh merged commit ec19b0a into main

yuri-tceretian mentioned this pull request

Alertmanager: Update alertmanager to grafana fork grafana/mimir#4796

Closed

3 tasks

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

3b87037

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana mentioned this pull request

Capture and expose notification delivery errors (#31) #43

Merged

grobinson-grafana added a commit that referenced this pull request


          Merge pull request #43 from grafana/grobinson/pick-9a8d1f9

803b73a

Capture and expose notification delivery errors (#31)

JohnnyQQQQ pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

e7d8cb3

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

JohnnyQQQQ mentioned this pull request

Capture and expose notification delivery errors (#31) #45

Merged

JohnnyQQQQ added a commit that referenced this pull request


          Merge pull request #45 from grafana/cherry-pick-errors-notifications

7d56305

Capture and expose notification delivery errors (#31)

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

afc7151

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

d59154b

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: George Robinson <george.robinson@grafana.com>

grobinson-grafana added a commit that referenced this pull request


          Merge pull request #46 from grafana/grobinson/cherry-pick-errors-noti…

8e302d2

…fications

Capture and expose notification delivery errors (#31)

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

8317e83

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana mentioned this pull request

Capture and expose notification delivery errors (#31) #47

Merged

grobinson-grafana added a commit that referenced this pull request


          Merge pull request #47 from grafana/grobinson/pick-ec19b0a

6af7ccb

Capture and expose notification delivery errors (#31)

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

3e5f6be

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana mentioned this pull request

Rebased main onto "Capture and expose notification delivery errors (#31)" #48

Merged

grobinson-grafana added a commit that referenced this pull request


          Merge pull request #48 from grafana/feature/errors-in-notifications-2

3513be6

Rebased main onto "Capture and expose notification delivery errors (#31)"

alexweav pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

c94074b

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

9ed91e1

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

f19587a

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

d2bf952

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

1d0500e

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

c07ba18

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

af0397d

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

7a9ad3e

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

08c6ce0

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

44dbf7b

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

838b0ff

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

grobinson-grafana pushed a commit that referenced this pull request


          Capture and expose notification delivery errors (#31)

5a69ba9

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the `/api/v2/receivers` endpoint.

Co-authored-by: gotjosh <josue.abreu@gmail.com>

diorcety commented May 16, 2024 •

edited

There is an issue with this merge:

+                       if _, found := activeReceiversMap[rcv.Name]; !found {
                                // No need to build a receiver if no route is using it.
                                level.Info(configLogger).Log("msg", "skipping creation of receiver not referenced by any route", "receiver", rcv.Name)
+                               receivers = append(receivers, notify.NewReceiver(rcv.Name, false, nil))
                                continue
                        }

       "required": [
-        "name"
+        "name",
+        "active",
+        "integrations"
       ],

Either the required is incorrect (can't tell) or at couple of places there is missing code. For example if active/integrations are required, AlertToOpenAPIAlert should be fixed !

@santihernandezc what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment