-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store info about last notification error in receivers #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, looks good. However, I think we should reduce the number of changes like renaming fields, double\single quotes. I think this will help push the changes upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the
/api/v2/receivers
endpoint.Related the errors in the notification pipeline epic in
grafana/grafana
.