Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store info about last notification error in receivers #8

Merged
merged 15 commits into from
Sep 15, 2022

Conversation

santihernandezc
Copy link

@santihernandezc santihernandezc commented Sep 12, 2022

This PR makes it possible to store the last error for each receiver in case of notification delivery failure. These errors are exposed via the /api/v2/receivers endpoint.

Related the errors in the notification pipeline epic in grafana/grafana.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2022

CLA assistant check
All committers have signed the CLA.

@santihernandezc santihernandezc marked this pull request as ready for review September 14, 2022 00:30
Copy link

@yuri-tceretian yuri-tceretian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks good. However, I think we should reduce the number of changes like renaming fields, double\single quotes. I think this will help push the changes upstream.

api/v2/openapi.yaml Outdated Show resolved Hide resolved
api/v2/models/integration.go Show resolved Hide resolved
api/v2/models/receiver.go Show resolved Hide resolved
notify/notify.go Outdated Show resolved Hide resolved
notify/notify.go Show resolved Hide resolved
notify/receiver.go Outdated Show resolved Hide resolved
notify/notify.go Outdated Show resolved Hide resolved
notify/notify.go Outdated Show resolved Hide resolved
Copy link

@yuri-tceretian yuri-tceretian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santihernandezc santihernandezc merged commit 6df3d7a into main Sep 15, 2022
@santihernandezc santihernandezc deleted the improve-receivers-api branch September 15, 2022 20:56
@santihernandezc santihernandezc mentioned this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants