-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify message format to publish on the bus #4
Comments
@jtlisi I think this is the next step for this adapter. Let me know what you think and if we have any idea in which format the customer expect the messages to be sent |
I agree, we are going to need to store the tenant ID. The ideal format for these messages will be JSON initially, if another format is requested we can add support for it later. |
We should remove AVRO from the CLI and publish the tenant ID in JSON format |
An important point to remember is that the tenant ID should be acquired through basic auth |
The message format (cf. https://github.com/grafana/prometheus-pulsar-remote-write/blob/7d5901bb9d0ac60313a50b85a309949ccbeb2a10/pulsar/serializers_test.go) how metrics are represented is based on the provided implementation from https://github.com/liangyuanpeng/prometheus-pulsar-adapter.
I think we should review this going forward and think about those conditions:
We should also consider using the properties fields and/or the EventTime of pulsar Messages(not for now)The text was updated successfully, but these errors were encountered: