Propagate tenant ID #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbaldry
approved these changes
Aug 4, 2020
| func NewJSONSerializer() *JSONSerializer { | ||
| return &JSONSerializer{} | ||
| type Sample struct { | ||
| Value model.SamplePair `json:"value"` |
There was a problem hiding this comment.
Would using Sample instead of Value as the struct field prevent the stuttering in "value": s.Value.Value.String(),?
There was a problem hiding this comment.
I get your point, but I think I probably would prefer to use the same name here that is used in the JSON annotation field how it defined upstream:
https://github.com/prometheus/common/blob/217fd62d44a79db8f842113234ae9383b8374983/model/value.go#L115
https://github.com/prometheus/common/blob/217fd62d44a79db8f842113234ae9383b8374983/model/value.go#L144
This add support for optional tenant IDs. It can recognize them both from the Basic Auth and the X-Scope-OrgID headers. The propagation is supported in all serialization formats using an optional fields.
simonswine
force-pushed
the
handle-tenant-id
branch
5 times, most recently
from
8c99b37
to
5dccb4e
Compare
simonswine
force-pushed
the
handle-tenant-id
branch
from
5dccb4e
to
415a686
Compare
Download modules through `go mod download` first.
simonswine
force-pushed
the
handle-tenant-id
branch
from
3ed3b9d
to
0888f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for optional tenant IDs. It can recognize them both from the Basic Auth and the X-Scope-OrgID headers. The propagation is supported in all serialization formats using an optional fields. (This fixes #4 in most parts).
I have written some integration tests, which require a pulsar endpoint to target. I will investigate how we can run that as part of CI
@jtlisi if you get the chance, take a look happy to get some review esp. for the non integration test part of it.