Add support for TLS auth #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
support-tls-client-auth
branch
2 times, most recently
from
ed4991e
to
f3fe571
Compare
|
I have tested a TLS connection locally. I think all the flags work as expected. Only If you want to reproduce that is what I am using: https://github.com/simonswine/grafana-local-dev/blob/3380705694a3be92ceffcd4d015220b6882cf9d9/jsonnet/docker-compose/pulsar/main.jsonnet |
simonswine
force-pushed
the
support-tls-client-auth
branch
from
f3fe571
to
2903167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the client auth flags from the upstream library.
I am currently working to configure pulsar with TLS so I can test it.
Fixes #5