Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom partitioning key #16

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

simonswine
Copy link
Collaborator

For de-duplicating messages from HA replicas, we need to ensure order of remote writes. To achieve that we are using the same partition key for metrics using the same labels (expect replica labels) and tenant-ids.

Fixes #3

Copy link

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

main.go Outdated Show resolved Hide resolved
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

pulsar/serializers.go Show resolved Hide resolved
For de-duplicating messages from HA replicas, we need to ensure order of
remote writes. To achieve that we are using the same partition key for
metrics using the same labels (expect replica labels) and tenant-ids.

Fixes #3
@simonswine simonswine force-pushed the implement-custom-partitioning branch from 963e4de to 641eb16 Compare August 6, 2020 15:02
@simonswine simonswine merged commit 6e77d37 into master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement custom partitioning
3 participants