Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GOX binary checksum and pin base image version to prevent it changing #27

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

jdbaldry
Copy link
Member

Signed-off-by: Jack Baldry jack.baldry@grafana.com

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry marked this pull request as ready for review September 23, 2020 09:26
@jdbaldry jdbaldry changed the title Add print statements for checksum mismatches Fix GOX binary checksum and pin base image version to prevent it changing Sep 25, 2020
RUN install -t /usr/local/bin golangci-lint-"${GOLANGCI_LINT_VERSION}"-linux-amd64/golangci-lint

FROM golang:1.14-stretch as gox-builder
FROM golang:1.14.9-stretch as gox-builder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth updating the "main" dockerfile to golang 1.14.9 as well

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry merged commit d14b419 into master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants