Break up the project and allow use subcommand #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable the addition of other modes. The default and only mode is produce, which should not break any existing users.
simonswine
force-pushed
the
breakup-into-subcommands
branch
from
154c96b
to
f73d9e3
Compare
jtlisi
approved these changes
Oct 30, 2020
| pulsar: &pulsarConfig{}, | ||
| } | ||
|
|
||
| cmd := app.app.Command(name, "Receive remote_write requests and produce messages on the pulsar bus").Default() |
There was a problem hiding this comment.
The default and only mode is produce, which should not break any existing users.
Question: When you set a command as Default() will it be the triggered command even if it's not provided?
There was a problem hiding this comment.
Yes exactly apart from --help, both commands behave exactly the same way
./prometheus-pulsar-remote-write --x y
./prometheus-pulsar-remote-write produce --x y
# will fail
./prometheus-pulsar-remote-write invalid
# will run consume
./prometheus-pulsar-remote-write consume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable the addition of other modes.
The default and only mode is produce, which should not break any
existing users.