-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests #29
Conversation
9bbdacc
to
c534996
Compare
Signed-off-by: Christian Simon <simon@swine.de>
Signed-off-by: Christian Simon <simon@swine.de>
Signed-off-by: Christian Simon <simon@swine.de>
Introduced through #33
c534996
to
d38b2a1
Compare
2009f8a
to
c7de57c
Compare
This should work pretty reliably both on drone and on Github Actions. |
@@ -73,7 +73,7 @@ func NewClient(config Config) (*Client, error) { | |||
} | |||
|
|||
func (c *Client) InitProducer() error { | |||
_, err := c.consumer() | |||
_, err := c.producer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug from the changes from #33, where the integration tests would have actually covered this problem 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.