Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies to their latest versions #44

Merged
merged 10 commits into from
Mar 9, 2023
Merged

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Mar 7, 2023

No description provided.

@rfratto
Copy link
Member Author

rfratto commented Mar 7, 2023

It looks like I need to revisit the CI and potentially update that too. All the tests were passing locally for me (except the integration tests, which I need to look into).

The Ack method can now return an error which needs to be handled. The
error is ignored when acknowledging a bad sample.
@rfratto rfratto marked this pull request as ready for review March 9, 2023 03:08
@rfratto rfratto requested a review from tpaschalis March 9, 2023 03:09
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit e1c75ea into master Mar 9, 2023
@rfratto rfratto deleted the update-deps branch March 9, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants